Repository navigation
Accept Reveal.js 6 - #10
Merged
Merged
Conversation
The peer range was ^4 || ^5, so installing slide-quiz into a deck on Reveal.js 6 (the latest since September 10) failed with ERESOLVE. The plugin calls getConfig, getRevealElement, on and off, which Reveal.js 6 keeps, and it works there unchanged: question, vote, correct-answer fragment, leaving the slide and destroy all behave as on 5. Reveal.js 6 ships its own RevealConfig type without plugin options, so a TypeScript object literal with slideQuiz fails the excess property check. The README shows passing the options through a variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Reveal.js 6 came out on September 10,
npm install reveal.jsinstalls 6. slide-quiz's peer range was^4.0.0 || ^5.0.0, sonpm install slide-quizin such a deck fails withERESOLVE.Change
^4.0.0 || ^5.0.0 || ^6.0.0. The plugin code doesn't change.RevealConfigtype doesn't list plugin options, so an object literal withslideQuizfails the excess property check. Passing the options through a variable type-checks.Verification
The same deck ran in headless Chromium on Reveal.js 5.2.1 and 6.0.2, with a real
anycable-goand a phone. On both versions:slidechanged.fragmentshownandfragmenthiddentoggle the correct answer.destroy()removes everything it injected.There were no page or console errors on either version.
I also packed the package and installed it into a fresh Reveal.js 6 deck:
vite buildsucceeds.tscpasses with the variable pattern from the README.npm test(155), the typecheck and the build pass.After merge: release 0.7.3, then let create-slide-quiz install the latest Reveal.js again.