Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Switch to rspack and add react-fast-refresh #1039

Closed
wants to merge 20 commits into from

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Nov 9, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

TODO: Will fill in shortly.
Remaining todos:

  • Clean up commits
  • Add video demo of react-fast-refresh
  • Validate all rspack package.json scripts are working

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Nov 9, 2024

CLA Assistant Lite bot:
Thank you for your pull request, we really appreciate it!

Please sign our Contributor License Agreement before we can accept your contribution.
You can sign the CLA by simply commenting on this pull request with the following text.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Copy link

@chrisirhc
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@chrisirhc
Copy link
Contributor Author

recheck

@chrisirhc chrisirhc closed this Nov 9, 2024
@chrisirhc chrisirhc reopened this Nov 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
@ra3orblade
Copy link
Contributor

Closing as duplicate.

@ra3orblade ra3orblade closed this Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants