-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch build to rspack and add react-fast-refresh #1040
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Not sure what happened to #1039 , the github actions bot limited it my interactions after I accidentally clicked Close. I can't do anything with that PR. If anyone can close it for me that'd be great. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Hello, thanks for the PR, I've checked the branch but |
Could you please share the error you're seeing? |
Missing module osx-temperature-sensor
url-loader -> asset/linline Reference: https://rspack.dev/guide/migration/webpack#file-loader--url-loader--raw-loader--asset-modules
Not sure why there are new packages found, investigate later.
Need to do some setup first before we can use react-refresh.
573b4a7
to
64c71e4
Compare
Took a first pass at cleaning up the PR so it's ready for a first review and comment. |
It works, but it works through webpack, maybe I didnt get something. I'll check again. Could you please rename webpack in all commands so it would be clear it's not webpack anymore? |
webpack-dev-server@5 is in use by rspack/server as per the documentation here. Is that what you meant? I can rename the remaining occurrences of webpack which are in 3 package.json scripts. It's used in the name of the script. |
I see, yes rename scripts pls. |
@chrisirhc merged, thanks! The code reload now works really fast. |
@any contributor @chrisirhc tooling |
Description
Rspack is rust-based web bundler that's intended to be a drop-in replacement for webpack that's fast.
The addition of react-fast-refresh now allows refreshes of React components in-place while the application is loaded without refreshing the page/window.
What I've tested so far manually:
npm run start:dev
npm run dist:mac
TODOs:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Cap.2024-11-10.at.09.08.56.mp4
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?