Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace width to translate #908

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

LavaCxx
Copy link
Contributor

@LavaCxx LavaCxx commented Aug 25, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

Using translate to replace the original left and width animations reduces the performance cost of page reflows.

The modified code should allow for the removal of some width-related sections, but I'm not certain which ones are essential.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Spaces & widgets

vault.mov

Only widgets

default.mov

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@ra3orblade
Copy link
Contributor

I think I can't approve this unfortunately as this was a design decision, but I will ask.

@haron-IV
Copy link

haron-IV commented Nov 5, 2024

I think I can't approve this unfortunately as this was a design decision, but I will ask.

Design decision? Can you elaborate a little?

@ra3orblade
Copy link
Contributor

The main problem with changing width animation to translate is that right now there is common code that controls the resize of the sidebar, page resize and elements animation, splitting this code into show/hide and resize may be done but it will complicate things much more and we do not have time at the moment for this change. Maybe it will be reviewed one more time with the introduction of the right panel. By design decision I meant that we have discussed it with designers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants