Image manager #120
Open
Image manager #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces a new image manager component for handling OCI (Open Container Initiative) image layers within the SM (Service Manager) module. The implementation provides functionality for unpacking layer archives, calculating directory digests, and determining unpacked layer sizes.
Key Changes:
- Added ImageHandler class with methods for layer unpacking, size calculation, and digest computation
- Refactored common utilities: renamed
HashDirtoCalculateDirDigestfor better clarity and extractedChangeOwnerinto a reusable utility function - Extended OCI spec support to handle rootfs configuration in image configs
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sm/imagemanager/imagehandler.hpp | Defines ImageHandler interface with Init, UnpackLayer, GetUnpackedLayerSize, and GetUnpackedLayerDigest methods |
| src/sm/imagemanager/imagehandler.cpp | Implements image layer handling including OCI whiteout conversion to overlayfs format |
| src/sm/imagemanager/tests/imagemanager.cpp | Adds test for layer unpacking, size calculation, and digest verification |
| src/sm/imagemanager/tests/CMakeLists.txt | Build configuration for image manager tests |
| src/sm/imagemanager/CMakeLists.txt | Build configuration for image manager module |
| src/sm/app/CMakeLists.txt | Integrates image manager library into SM application |
| src/sm/CMakeLists.txt | Adds image manager subdirectory to SM build |
| src/common/utils/image.hpp | Renames HashDir to CalculateDirDigest and updates ParseDigest signature |
| src/common/utils/image.cpp | Updates digest calculation to include relative file paths and standardizes error message casing |
| src/common/utils/filesystem.hpp | Adds ChangeOwner utility function declaration |
| src/common/utils/filesystem.cpp | Implements ChangeOwner to recursively change file/directory ownership |
| src/common/utils/fsplatform.cpp | Refactors ChangeOwner to use new filesystem utility function |
| src/common/utils/tests/image.cpp | Updates test name from HashDirTest to CalculateDirDigest |
| src/common/ocispec/imageconfig.cpp | Adds rootfs parsing and serialization support for OCI image configs |
| src/common/ocispec/tests/ocispec.cpp | Adds rootfs test data to image config test fixture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
image_manager
branch
from
5c95de7 to
8db8493
Compare
Move ChangeOwner to filesystem in order to use it without FS platform instance. Signed-off-by: Oleksandr Grytsov <[email protected]>
Rename HashDir to CalculateDirDigest and uses Digest type name. Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
image_manager
branch
from
8db8493 to
83e8c13
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_unification #120 +/- ##
======================================================
Coverage ? 82.20%
======================================================
Files ? 266
Lines ? 25209
Branches ? 2620
======================================================
Hits ? 20724
Misses ? 4485
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement image handler interface for SM image manger. Most parts are taken from previous image module. Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
image_manager
branch
from
83e8c13 to
e2f36a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.