cm: database: persist version in launcher::InstanceInfo #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_unification #136 +/- ##
======================================================
Coverage ? 82.19%
======================================================
Files ? 300
Lines ? 28031
Branches ? 2986
======================================================
Hits ? 23039
Misses ? 4992
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
al1img
reviewed
Jan 20, 2026
| *mSession << "INSERT INTO launcher_instances (itemID, subjectID, instance, type, manifestDigest, " | ||
| "nodeID, prevNodeID, runtimeID, uid, gid, timestamp, state, isUnitSubject) " | ||
| "VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);", | ||
| "nodeID, prevNodeID, runtimeID, uid, gid, timestamp, state, isUnitSubject, version) " |
Collaborator
There was a problem hiding this comment.
What about ownerID and subjectType? Are they stored in db?
Collaborator
Author
There was a problem hiding this comment.
no, should add to InstanceInfo
MykolaSuperman
approved these changes
Jan 21, 2026
MykolaSuperman
left a comment
MykolaSuperman
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.