common:ocispec: fix device name field#14
Merged
al1img merged 1 commit intoaosedge:developfrom Jun 24, 2025
Merged
Conversation
mykola-kobets-epam
approved these changes
Jun 19, 2025
mlohvynenko
approved these changes
Jun 20, 2025
MykolaSuperman
approved these changes
Jun 20, 2025
mlohvynenko
approved these changes
Jun 24, 2025
Member
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
al1img
force-pushed
the
fix_service_config_device
branch
2 times, most recently
from
94cf3af to
2be2e49
Compare
According to spec service device field is named as "name" instead of "device". Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
al1img
force-pushed
the
fix_service_config_device
branch
from
2be2e49 to
d715f1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
==========================================
Coverage ? 78.48%
==========================================
Files ? 193
Lines ? 21088
Branches ? 2037
==========================================
Hits ? 16550
Misses ? 4538
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to spec service device field is named as "name" instead of "device".