spaceallocator: fix Resize to properly free and allocate space #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_unification #466 +/- ##
=======================================================
+ Coverage 84.49% 84.52% +0.02%
=======================================================
Files 293 293
Lines 25025 25066 +41
Branches 3413 3417 +4
=======================================================
+ Hits 21146 21186 +40
- Misses 3879 3880 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mlohvynenko
reviewed
Jan 12, 2026
| return err; | ||
| } | ||
|
|
||
| if (auto err = mPartition->Allocate(newSize); !err.IsNone()) { |
Member
There was a problem hiding this comment.
if an error occurs, shouldn't SpaceAllocator::Free be called?
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
MykolaSuperman
force-pushed
the
fix_resize_spaceallocator
branch
from
c7a0e1d to
c010565
Compare
|
mlohvynenko
approved these changes
Jan 13, 2026
Member
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
mykola-kobets-epam
approved these changes
Jan 19, 2026
Contributor
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.