cm: smcontroller: update design document #485
Conversation
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
There was a problem hiding this comment.
Pull request overview
Updates the SM controller design document to reflect using imagemanager::ItemInfoProviderItf (instead of BlobInfoProviderItf) for providing item/blob-related information (e.g., blob URLs) to SM.
Changes:
- Replaced
BlobInfoProviderItfwithItemInfoProviderItfin the “required interfaces” list. - Updated the Mermaid class diagram to reference
ItemInfoProviderItfand its dependency fromSMController.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * [aos::crypto::CertLoaderItf](../../common/crypto/itf/certloader.hpp) - loads certificates; | ||
| * [aos::crypto::x509::ProviderItf](../../common/crypto/itf/x509provider.hpp) - provides crypto operations; | ||
| * [aos::cm::imagemanager::BlobInfoProviderItf](../imagemanager/itf/blobinfoprovider.hpp) - provides blob info; | ||
| * [aos::cm::imagemanager::ItemInfoProviderItf](../imagemanager/itf/iteminfoprovider.hpp) - provides items info; |
There was a problem hiding this comment.
The interface description is a bit inaccurate/vague: ItemInfoProviderItf specifically provides update item info (and includes blob path/URL methods). Consider updating the bullet text to match the interface intent (e.g., “provides update item info / blob URL/path info”) so the design doc remains precise.
| * [aos::cm::imagemanager::ItemInfoProviderItf](../imagemanager/itf/iteminfoprovider.hpp) - provides items info; | |
| * [aos::cm::imagemanager::ItemInfoProviderItf](../imagemanager/itf/iteminfoprovider.hpp) - provides update item info and blob URL/path info; |
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_unification #485 +/- ##
====================================================
Coverage 84.78% 84.79%
====================================================
Files 299 299
Lines 25866 25866
Branches 3489 3490 +1
====================================================
+ Hits 21931 21932 +1
+ Misses 3935 3934 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SM controller should use imagemanager::ItemInfoProviderItf instead of imagemanager::BlobInfoProviderItf to provide blob URL's to SM. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
|
3 participants
SM controller should use imagemanager::ItemInfoProviderItf instead of imagemanager::BlobInfoProviderItf to provide blob URL's to SM.