add "enable_tracemalloc" to log memory usage in scheduler #42304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
kaxil,
XD-DENG,
ashb,
o-nikolas,
pierrejeambrun and
hussein-awala
as code owners
boring-cyborg
bot
added
the
area:Executors-core
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
from
a8cf17a
to
018f672
Compare
Lee-W
changed the title
Lee-W
changed the title
vincbeck
reviewed
Sep 18, 2024
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
from
018f672
to
32662af
Compare
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
2 times, most recently
from
41f7848
to
91bc47f
Compare
o-nikolas
approved these changes
Sep 19, 2024
jedcunningham
approved these changes
Sep 19, 2024
vincbeck
approved these changes
Sep 19, 2024
phanikumv
reviewed
Sep 20, 2024
|
Random thought: Maybe we move this tracemalloc behavior into sigusr1? Just seems like maybe having a debug dump like we do today in sigusr2 and keeping performance impacts to stuff in sigusr1 might be a better approach. |
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
from
0b43901
to
867908b
Compare
Sounds good! Just move it to SIGUSR1. Another thing I just noticed is that this might not be helpful if we start when receiving a signal. We probably still need to start it before that. Do you think making it a config makes sense? |
uranusjr
reviewed
Sep 23, 2024
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
2 times, most recently
from
66268c7
to
c74f569
Compare
Lee-W
force-pushed
the
log-memory-usage-in-executor
branch
from
c74f569
to
431ea75
Compare
Lee-W
changed the title
|
I'm thinking of merging this one later today if no one has more thoughts. Thanks! |
phanikumv
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
add more information to ease the debugging process when receiving sigurs1
What
log memory usage in the scheduler when handling sigurs1 if enable_tracemalloc is set
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.