KubernetesPodOperator never stops if credentials are refreshed #42361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolo-moriello
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
romsharon98
reviewed
Sep 21, 2024
paolo-moriello
force-pushed
the
cncf-k8s-pod-operator-401
branch
from
f28c328
to
0c0787c
Compare
romsharon98
approved these changes
Sep 23, 2024
paolo-moriello
force-pushed
the
cncf-k8s-pod-operator-401
branch
from
0c0787c
to
389a59a
Compare
paolo-moriello
force-pushed
the
cncf-k8s-pod-operator-401
branch
from
389a59a
to
815d765
Compare
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…e#42361) * Never stop retrying 401s in k8s pod operator * Try reading pod after refreshing credentials * Never stop retrying until credentials are refreshed * Linting --------- Co-authored-by: pmoriello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of this PR: #39325
With the above change, the tenacity retry mechanism was introduced while waiting pod completion. For long running tasks, in fact, k8s credentials could expire while the task is still running, we are therefore refreshing credentials and retrying. However this did not completely solve the issue due to the
stop_after_attempt(3): the job is still failing when credentials were expiring more than twice.This PR attempts at fixing this issue by:
stop_after_attemptlogic^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.