-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AIP-84): Add auth for ui config #47487
Conversation
822b7aa
to
fcd084f
Compare
fcd084f
to
66b26b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to adapt the UI, because this will break it.
The config call from the UI is done before loading the layout (router level), and therefore after successful authentication, we do not reach the code that handle the token and issue a ui/config
query before that, resulting in a 401 loop. 😬
I'll take a look to try to unblock this, thanks for the PR. |
got it. Thanks @pierrejeambrun . let me mark it as draft first |
66b26b2
to
2351ba4
Compare
#47562 this will fix the issue and needs to be merged first. Tested with this PR change and mine, things are working as expected. |
I tried to take a look... but not familiar with that part.... I will rebase once that's merged. Thanks! |
#47562 merged! rebased |
2351ba4
to
7337430
Compare
Static check need fixing (maybe you should run precommit locally to avoid this, especially when the API CI is full test -> very long) |
hmmm... weird. changed nothing since the last CI green. |
7337430
to
7a1fa41
Compare
nothing can be fixed by running pre-commit locally 🤔 let me push it again and see how it works |
As this is approved and CI is green, gonna merge it |
Why
#42360
blocked by #47208merged^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.