Hide task duration if we don't have a start_date #47633
Conversation
jedcunningham
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the task header display logic to conditionally show the duration only when a start_date is present, thereby avoiding negative duration displays when start_date is missing.
- Wrapped the duration field in a conditional check using Boolean(taskInstance.start_date)
- Ensures that running tasks (with a start_date) still display duration even if the end_date is missing
|
Good catch! Is this true for dag runs too or only TIs? We should also add a check to https://github.com/apache/airflow/blob/main/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx#L140, https://github.com/apache/airflow/blob/main/airflow/ui/src/pages/TaskInstance/Details.tsx#L135, |
I think just TIs. |
In some failure scenarios, we can have an end_date without a start_date. If we naively show a duration in these cases, we end up with a negative duration, which isn't ideal. This hides the duration if we don't have start_date. End_date wasn't added to the condition so a duration is still shown for running tasks - those with a start_date but no end_date.
jedcunningham
force-pushed
the
hide_duration_if_no_start_date
branch
from
b42b0a5 to
6d6c9ae
Compare
Done! Sorry, I should have looked around a bit more :) |
In some failure scenarios, we can have an end_date without a start_date. If we naively show a duration in these cases, we end up with a negative duration, which isn't ideal. This hides the duration if we don't have start_date.
End_date wasn't added to the condition so a duration is still shown for running tasks - those with a start_date but no end_date.
Closes: #47632
With both dates:
With missing end date:
