Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset expression schedule popover #47645

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 11, 2025

For asset triggered dags, add a popover to the Schedule component to see a visualization of the asset conditions to trigger the dag.

  • For regularly scheduled dags, the schedule is just text with a tooltip. For Asset-triggered dags, it is a button to open a popover

  • Added asset_expression to ui/dags

  • To Do: Add event info and links to the asset details page when we add asset_id to asset_expression. Right now there is no good way to connect an expression to its actual asset. We can use this to show the queue for the next dag run, or if a dag run is selected, what events caused that dag to trigger. We could also add the Asset Event Creation trigger inside this popover.

Screenshot 2025-03-11 at 5 12 25 PM Screenshot 2025-03-11 at 5 12 36 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 11, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@bbovenzi bbovenzi force-pushed the add-schedule-popover branch from 8c954c5 to a936dd3 Compare March 11, 2025 22:58
@kaxil kaxil merged commit 62969b6 into apache:main Mar 12, 2025
86 of 89 checks passed
@kaxil kaxil deleted the add-schedule-popover branch March 12, 2025 07:27
@kaxil
Copy link
Member

kaxil commented Mar 12, 2025

CI failures are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants