Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove gtag code #1845

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: remove gtag code #1845

merged 1 commit into from
Jan 20, 2025

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 17, 2025 •
edited
Loading

Fixes: #1847

Changes:

  1. remove gtag id code

Screenshots of the change:

@SkyeYoung
Copy link
Member

@guoqqqi Move the issue here?

SkyeYoung
SkyeYoung approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@SkyeYoung SkyeYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM.

@guoqqqi
Copy link
Member Author

guoqqqi commented Jan 20, 2025

@guoqqqi Move the issue here?

done

@guoqqqi guoqqqi merged commit e2f9126 into apache:master Jan 20, 2025
3 checks passed
@guoqqqi guoqqqi deleted the fix/remove-ga-code branch January 20, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzeng25 yzeng25 yzeng25 approved these changes

@SkyeYoung SkyeYoung SkyeYoung approved these changes

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Remove Google Analytics from APISIX Website
3 participants
@guoqqqi @SkyeYoung @yzeng25