-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(http-logger): add max request and response body size attributes #12065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(http-logger): add max request and response body size attributes #12065
Conversation
Hi @shreemaan-abhishek! |
Hi @MariaLapovska, are you currently experiencing any difficulties? Please describe in more detail so that others can help. |
@Baoyuantop I have added |
Hi @MariaLapovska, we can create an issue detailing this requirement and ensure that the change is justified through community discussion |
Hi @Baoyuantop ! I added feature request here - #12130 |
@MariaLapovska if you spend a little time reading the tests you will understand that they are very simple. Most of the test cases consist of apisix configurations. If you have any specific questions feel free to ask and the community will help. |
Hi @MariaLapovska, are you still working on this PR? |
@Baoyuantop yes - I'll add tests, and I've created an issue detailing this feature, but there's no discussion in it |
Description
In some cases APISIX users might want to customize the max size of request/response body sent to HTTP server via
http-logger
plugin to be lower/higher than the current default value of 512KiB.For this purpose two new attributes are introduced to
http-logger
plugin (similar to the existing ones inkafka-logger
, taking advantage of the functionality that's already implemented inlog-util
):max_resp_body_bytes
max_req_body_bytes
Checklist