Skip to content

Aries 2120 Change DistributionProvider to return a Closeable ImportedService so that resources can be properly released #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Aries 2120 Change DistributionProvider to return a Closeable ImportedService so that resources can be properly released #57

wants to merge 2 commits into from

Conversation

amichair
Copy link
Contributor

Note: This changes the SPI interface as discussed in the JIRA, so should probably go into the 2.0.0 release.

alien11689
alien11689 reviewed Jun 29, 2025
View reviewed changes
Copy link

@alien11689 alien11689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left one small blocking comment, beside that it looks good to me

alien11689
alien11689 approved these changes Jun 29, 2025
View reviewed changes
Copy link

@alien11689 alien11689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alien11689 alien11689 alien11689 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amichair @alien11689