refactor!: move get to ObjectStoreExt
#532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/os-ext-get
branch
2 times, most recently
from
bc30624 to
f5fe13a
Compare
crepererum
changed the title
get to ObjectStoreExt (#530)get to ObjectStoreExt
kylebarron
approved these changes
Nov 6, 2025
Member
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
Just a note on the conventional commit title (if we're trying to follow conventional commits?): since this is a breaking change I'd make the prefix refactor!: description
crepererum
changed the title
get to ObjectStoreExtget to ObjectStoreExt
crepererum
force-pushed
the
crepererum/os-ext-get
branch
from
f5fe13a to
8a27427
Compare
Contributor
Author
I don't know if we do. This is mostly my personal habit, but you're rightfully pointing out the missing "breaking" marker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See #385 and #405.
Rationale for this change
getis justget_optswith default options.What changes are included in this PR?
Are there any user-facing changes?
Breaking:
getmoved fromObjectStoretoObjectStoreExt.