feat: impl display for DataType::List
#7051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
added
api-change
tustvold
reviewed
Jan 31, 2025
| DataType::List(Arc::new(Field::new_list_field(DataType::UInt64, false))); | ||
| let list_data_type_string = list_data_type.to_string(); | ||
| let expected_string = "List(UInt64)"; | ||
| assert_eq!(list_data_type_string, expected_string); |
There was a problem hiding this comment.
Perhaps we could get a test of a nested list as well
|
Thanks @tustvold , I have made the changes as you suggested. Could you please help review it again? |
tustvold
reviewed
Feb 1, 2025
| @@ -458,7 +458,16 @@ pub enum UnionMode { | |||
|
|
|||
| impl fmt::Display for DataType { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| write!(f, "{self:?}") | |||
| match self { | |||
| DataType::List(field) => { | |||
There was a problem hiding this comment.
We also need to print the field name here if it isn't the default of item
There was a problem hiding this comment.
Right -- so if field.name() != "item" perhaps it could look like
List(Int8;N, field='foo')
Likewise, if there is metadata I think it should also be displayed like
List(Int8;N, field='foo', metadata)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7048
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?