feat: add new_unchecked method for RecordBatch
#7072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll comment on the issue, but if this is a bottleneck in your code it indicates a fairly major code smell. The cost of creating RecordBatch/arrays should be amortised over thousands of rows. Adding new_unchecked will not eliminate the fundamental problem with such code, and I'm therefore fairly lukewarm on this |
|
Looks like there is an alternate approach described in #7071 (comment) so marking this one as draft . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7071
Rationale for this change
See linked issue
What changes are included in this PR?
Added
new_uncheckedmethod forRecordBatchand changed all internal calls to use itAre there any user-facing changes?
new function on record batch