Refactor NullBufferBuilder to use an internal state machine
#7082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Feb 6, 2025
| @@ -83,7 +83,7 @@ impl BooleanBufferBuilder { | |||
| self.len == 0 | |||
| } | |||
|
|
|||
| /// Returns the capacity of the buffer | |||
| /// Returns the capacity of the buffer (in bits) | |||
There was a problem hiding this comment.
This (and accompanying changes to how this is handled by callers) is technically unrelated to original intent; just something I picked up, can probably be extracted to a separate PR
Comment on lines
+205
to
+208
| // TODO: Only usage of self.initial_capacity here. Should we be using it, | ||
| // or instead should use bitmap_builder.capacity()? Considering | ||
| // self.initial_capacity <= bitmap_builder.capacity() | ||
| capacity: self.initial_capacity, |
There was a problem hiding this comment.
This is to preserve the current behaviour of finish() where it resets to the original capacity provided. This seems wrong to me as ideally would want to reset to the current capacity, which may have increased since it was originally specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the course of #7013 I realized how confusing the internals of
NullBufferBuilderare, how some private fields are applicable only when the builder is in a certain state; this isn't enforced in the code, rather via comments (and knowledge of the struct).Experimenting with refactoring it to use an internal state machine to explicitly delineate the different states it can have and therefore enforce at compile time the rules which were previously implicit before.