Benchmarks for Arrow IPC reader #7091
Draft
+359
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 6, 2025
| }); | ||
| } | ||
|
|
||
| // copied from the zero_copy_ipc example. |
There was a problem hiding this comment.
I did want to benchmark using mmap as I think it is an important usecase
Maybe we should contemplate making this IPCBufferDecoder its own real API 🤔
| }) | ||
| }); | ||
|
|
||
| group.bench_function("FileReader/read_10/mmap", |b| { |
There was a problem hiding this comment.
The benchmark for mmap shows even more time spent in validating
3 tasks
alamb
commented
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #7090
Which issue does this PR close?
Rationale for this change
Similarly to #7090 we need a benchmark to show efforts to improve validation will actually speed it up.
What changes are included in this PR?
Are there any user-facing changes?
No, this is only benchmark code
As you can see by the flamegraph, indeed most of the time is spent validating data (UTF8 validation specifically)