Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store/gcp: derive Clone for GoogleCloudStorage #7112

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

james-rms
Copy link
Contributor

@james-rms james-rms commented Feb 10, 2025

Which issue does this PR close?

Closes #7113.

Rationale for this change

Deriving Clone will be useful for callers who wish to take advantage of the Arc and and share ownership across threads or callsites.

Are there any user-facing changes?

Users will see the new derive in docs.

@github-actions github-actions bot added the object-store Object Store Interface label Feb 10, 2025
@james-rms james-rms marked this pull request as ready for review February 11, 2025 00:00
Copy link
Contributor

@Kinrany Kinrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing of object_store's implementation details but AmazonS3 is Clone as well, so there's precedent at least.

@tustvold tustvold merged commit 19f01e3 into apache:main Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_store: GCSObjectStore should derive Clone
3 participants