Skip to content

Cast support for RunEndEncoded arrays #8589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 26, 2025
Merged

Cast support for RunEndEncoded arrays #8589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ca051e2
Implemented casting for RunEnd Encoding
rich-t-kid-datadog Jun 19, 2025
60c52b4
Implemented casting for RunEnd Encoding
rich-t-kid-datadog Jun 19, 2025
0a6d865
feat: Add Run-End Encoded array casting with overflow protection
rich-t-kid-datadog Jun 23, 2025
8b434d4
feat: Add Run-End Encoded array casting with overflow protection
rich-t-kid-datadog Jun 23, 2025
77cda81
Use type specific zero-copy comparisons in cast_to_run_end_encoded
vegarsti Oct 11, 2025
b666a97
Move tests in mod run_end_encoded_tests into mod tests
vegarsti Oct 11, 2025
6eafcea
panic if REE in cast_to_run_end_encoded
vegarsti Oct 11, 2025
3c2e837
Use unreachable macro
vegarsti Oct 11, 2025
d1e5120
Simplify some assertions
vegarsti Oct 11, 2025
2358010
Extract populate_run_ends_and_values, which casts then iterates to id…
vegarsti Oct 11, 2025
7ed2872
Add missing Float16 and Decimal types to can_cast_to_run_end_encoded
vegarsti Oct 12, 2025
692f6ea
Use a macro for packing runs
vegarsti Oct 12, 2025
b8c0754
Use partition from arrow-ord to find runs
vegarsti Oct 15, 2025
bdcaa4b
Remove cast_options.safe = false
vegarsti Oct 18, 2025
e086d4c
Simplify variables in partition loop
vegarsti Oct 18, 2025
a16d555
Partition on cast_array, not array
vegarsti Oct 18, 2025
82c384b
Support casting from dictionary types and add test for that
vegarsti Oct 18, 2025
694814c
Remove can_cast_to_run_end_encoded
vegarsti Oct 25, 2025
17f4f6f
Improve run_end_encoded_cast, cast_to_run_end_encoded
vegarsti Oct 25, 2025
42c4044
Address comments on tests
vegarsti Oct 25, 2025
2f2c5e6
Appease clippy
vegarsti Oct 25, 2025
2a1f80f
Add the index in an out of range error message
vegarsti Oct 26, 2025
aab0084
Add apache license to pass RAT
alamb Oct 26, 2025
5e43f67
Merge remote-tracking branch 'apache/main' into cast-run-end-encoded-…
alamb Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arrow-cast/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ force_validate = []
arrow-array = { workspace = true }
arrow-buffer = { workspace = true }
arrow-data = { workspace = true }
arrow-ord = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are trying to keep the number of dependencies to a minimum

I see this is used to call partition which is clever but overly general. I think you can also partition a (single) column using eq and an offset to look for consecutive rows which are different.

Something like

let arr = ...;
let arr_shift1 = arr.slice(1, arr.len()-1);
let transitions = eq(arr, arr_shift_1);

However, the eq kernels is also in arrow-ord so I am not sure there is a way around it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's nice!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it suffice here to file an issue for potentially getting rid of this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I'm reading this is eq might be faster but won't get rid of the dependency, but getting rid of the dependency would be the best option. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #8708 for getting rid of arrow-ord and #8707 for performance improvement

arrow-schema = { workspace = true }
arrow-select = { workspace = true }
chrono = { workspace = true }
Expand Down
Loading
Loading