Check level byte length to avoid panic #8889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
approved these changes
Nov 20, 2025
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Thanks @rambleraptor, this looks good. Just a few micro-optimizations to consider 😅
If this is erroring for you, it makes me want to check farther upstream and see if we can detect this when we decode the page header.
| @@ -437,6 +437,9 @@ where | |||
| let mut offset = 0; | |||
|
|
|||
| if max_rep_level > 0 { | |||
| if offset > buf.len() { | |||
Contributor
There was a problem hiding this comment.
This one should never evaluate true?
| } | ||
|
|
||
| if offset > buf.len() { |
Contributor
There was a problem hiding this comment.
If the checks above are moved to after offset is incremented, then I think this check can be eliminated as it will either always be true (offset is still 0), or the error condition was already caught.
| } | ||
|
|
||
| let def_levels_end = rep_levels_byte_len + def_levels_byte_len; |
Contributor
There was a problem hiding this comment.
Why not move this check higher up and check all levels in one shot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Check level byte length to avoid panic
We've found a panic in our testing in these certain areas. I've added tests to help show when the errors would be thrown.