GH-35623: [C++][Python] FixedShapeTensorType.ToString() should print the type's parameters#36496
Merged
AlenkaF merged 7 commits intoapache:mainfrom Oct 9, 2023
Merged
Conversation
github-actions
bot
added
Component: C++
Component: Python
Component: Documentation
awaiting review
rok
reviewed
Jul 6, 2023
Member
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
This would be useful! Let's add a c++ test and consider a JSON string?
github-actions
bot
added
awaiting changes
AlenkaF
force-pushed
the
gh-35623-tensor-type-str
branch
from
be44ed5 to
a79ac96
Compare
Member
Author
|
@rok @jorisvandenbossche this should be ready for review with the suggestions included. |
rok
reviewed
Aug 24, 2023
Member
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
Leaving a suggestion for string helpers. LGTM otherwise!
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
rok
approved these changes
Oct 2, 2023
Member
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
Looks great! Thanks for adding the utility function!
github-actions
bot
added
awaiting merge
bkietz
requested changes
Oct 2, 2023
github-actions
bot
added
awaiting changes
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
github-actions
bot
added
awaiting change review
bkietz
approved these changes
Oct 5, 2023
github-actions
bot
added
awaiting merge
Member
Author
|
Thank you all for the reviews and suggestions! |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 76f987e. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 76f987e. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…print the type's parameters (apache#36496) ### Rationale for this change The string representation of two different `FixedShapeTensorType` objects is currently the same: `extension<arrow.fixed_shape_tensor>`. ### What changes are included in this PR? Override general type `ToString()` method for `FixedShapeTensorType`. The string representation of a tensor in this PR is proposed as follows: ``` extension<arrow.fixed_shape_tensor[value_type=*, shape=[*]] ``` ### Are these changes tested? Yes, in Python and in C++. ### Are there any user-facing changes? No. * Closes: apache#35623 Lead-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…print the type's parameters (apache#36496) ### Rationale for this change The string representation of two different `FixedShapeTensorType` objects is currently the same: `extension<arrow.fixed_shape_tensor>`. ### What changes are included in this PR? Override general type `ToString()` method for `FixedShapeTensorType`. The string representation of a tensor in this PR is proposed as follows: ``` extension<arrow.fixed_shape_tensor[value_type=*, shape=[*]] ``` ### Are these changes tested? Yes, in Python and in C++. ### Are there any user-facing changes? No. * Closes: apache#35623 Lead-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The string representation of two different
FixedShapeTensorTypeobjects is currently the same:extension<arrow.fixed_shape_tensor>.What changes are included in this PR?
Override general type
ToString()method forFixedShapeTensorType. The string representation of a tensor in this PR is proposed as follows:Are these changes tested?
Yes, in Python and in C++.
Are there any user-facing changes?
No.