Skip to content

MINOR: [CI][Docs][R] fix R dev docs#37595

Merged
assignUser merged 2 commits intoapache:mainfrom
boshek:fix/r-docs
Sep 6, 2023
Merged

MINOR: [CI][Docs][R] fix R dev docs#37595
assignUser merged 2 commits intoapache:mainfrom
boshek:fix/r-docs

Conversation

@boshek
Copy link
Contributor

@boshek boshek commented Sep 6, 2023

Rationale for this change

This fixes this failing build: https://github.com/apache/arrow-site/actions/runs/5745111541/job/15572612431#step:9:27

What changes are included in this PR?

That job is now called test-ubuntu-22.04-docs and started running the day after test-ubuntu-default-docs stopped running. I wasn't sure if it was possible (or worth it) to extend the task template into the ruby file so I just opted for a code comment for future changes.

Are these changes tested?

Are there any user-facing changes?

dev docs will build again

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 6, 2023
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for taking care of this!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 6, 2023
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 14.0.0 milestone Sep 6, 2023
@assignUser assignUser changed the title MINOR: [R] fix R dev docs MINOR: [CI][Docs][R] fix R dev docs Sep 6, 2023
@assignUser assignUser merged commit 7f604b2 into apache:main Sep 6, 2023
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Sep 6, 2023
@kou
Copy link
Member

kou commented Sep 7, 2023

Oh, sorry. Thanks!

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 7f604b2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

This fixes this failing build: https://github.com/apache/arrow-site/actions/runs/5745111541/job/15572612431#step:9:27

### What changes are included in this PR?

That job is now called `test-ubuntu-22.04-docs` and started running the day after `test-ubuntu-default-docs` stopped running. I wasn't sure if it was possible (or worth it) to extend the task template into the ruby file so I just opted for a code comment for future changes. 

### Are these changes tested?

### Are there any user-facing changes?

dev docs will build again

Lead-authored-by: Sam Albers <sam.albers@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

This fixes this failing build: https://github.com/apache/arrow-site/actions/runs/5745111541/job/15572612431#step:9:27

### What changes are included in this PR?

That job is now called `test-ubuntu-22.04-docs` and started running the day after `test-ubuntu-default-docs` stopped running. I wasn't sure if it was possible (or worth it) to extend the task template into the ruby file so I just opted for a code comment for future changes. 

### Are these changes tested?

### Are there any user-facing changes?

dev docs will build again

Lead-authored-by: Sam Albers <sam.albers@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants