GH-40055: [Java][Docs] Simplify use of Filter and Expression into Dataset Substrait #40056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Documentation
awaiting review
kou
changed the title
vibhatha
reviewed
Feb 13, 2024
| } | ||
| } | ||
|
|
||
| .. code-block:: text | ||
|
|
||
| ADD_TEN_TO_COLUMN_N_REGIONKEY CONCAT_COLUMNS_N_NAME_AND_N_COMMENT | ||
| column-1 column-2 |
There was a problem hiding this comment.
@davisusanibar I guess this column name changes occur from the Substrait end?
There was a problem hiding this comment.
Yes, it is.
I just created this issue for enhancements "Produce projection/filter extended expressions with predefined column names" substrait-io/substrait-java#229
github-actions
bot
added
awaiting committer review
vibhatha
reviewed
Feb 13, 2024
| while (reader.loadNextBatch()) { | ||
| System.out.println( | ||
| reader.getVectorSchemaRoot().contentToTSVString()); | ||
| System.out.println(reader.getVectorSchemaRoot().contentToTSVString()); |
There was a problem hiding this comment.
nit: does this need formatting. I am merely asking this comparing with the existing code.
There was a problem hiding this comment.
I'll review how a linter will be configured/implemented for Java code.
vibhatha
approved these changes
Feb 13, 2024
lidavidm
approved these changes
Feb 15, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a03d957. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…to Dataset Substrait (apache#40056) ### Rationale for this change Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new [Substrait Feature for SQL Expressions](https://github.com/substrait-io/substrait-java/releases/tag/v0.26.0). ### What changes are included in this PR? Update Apache Arrow Java Dataset Substrait documentation ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#40055 Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: David Li <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…to Dataset Substrait (apache#40056) ### Rationale for this change Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new [Substrait Feature for SQL Expressions](https://github.com/substrait-io/substrait-java/releases/tag/v0.26.0). ### What changes are included in this PR? Update Apache Arrow Java Dataset Substrait documentation ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#40055 Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: David Li <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…to Dataset Substrait (apache#40056) ### Rationale for this change Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new [Substrait Feature for SQL Expressions](https://github.com/substrait-io/substrait-java/releases/tag/v0.26.0). ### What changes are included in this PR? Update Apache Arrow Java Dataset Substrait documentation ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#40055 Authored-by: david dali susanibar arce <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new Substrait Feature for SQL Expressions.
What changes are included in this PR?
Update Apache Arrow Java Dataset Substrait documentation
Are these changes tested?
Yes
Are there any user-facing changes?
No