Skip to content

GH-40348: [Python] Add Python wrapper for VariableShapeTensor #40354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rok wants to merge 5 commits into
base: main
Choose a base branch
from
+1,174 −19
Open

GH-40348: [Python] Add Python wrapper for VariableShapeTensor #40354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f84762
GH-38007: [Python] Add VariableShapeTensor Python bindings
rok Feb 24, 2026
dee2f30
fixes
rok Feb 26, 2026
20c866a
further python work
rok Feb 26, 2026
9cb9a46
lint
rok Feb 26, 2026
0eef0a3
refactor
rok Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/extension/variable_shape_tensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ Result<std::shared_ptr<Tensor>> VariableShapeTensorType::MakeTensor(
internal::Permute<std::string>(permutation, &dim_names);
}

internal::Permute<int64_t>(permutation, &shape);
ARROW_ASSIGN_OR_RAISE(
auto strides, internal::ComputeStrides(ext_type.value_type(), shape, permutation));
internal::Permute<int64_t>(permutation, &shape);

Comment on lines +265 to 268
Copy link
Member Author

@rok rok Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking thinking about this still. It's probably a bug or a different interpretation at least.

ARROW_ASSIGN_OR_RAISE(const auto buffer,
internal::SliceTensorBuffer(*data_array, value_type, shape));
Expand Down
1 change: 1 addition & 0 deletions docs/source/python/api/arrays.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ may expose data type-specific methods or properties.
JsonArray
UuidArray
Bool8Array
VariableShapeTensorArray

.. _api.scalar:

Expand Down
6 changes: 5 additions & 1 deletion python/pyarrow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ def print_entry(label, value):
dictionary,
run_end_encoded,
bool8, fixed_shape_tensor, json_, opaque, uuid,
variable_shape_tensor,
field,
type_for_alias,
DataType, DictionaryType, StructType,
Expand All @@ -178,6 +179,7 @@ def print_entry(label, value):
RunEndEncodedType, Bool8Type, FixedShapeTensorType,
JsonType, OpaqueType, UuidType,
UnknownExtensionType,
VariableShapeTensorType,
register_extension_type, unregister_extension_type,
DictionaryMemo,
KeyValueMetadata,
Expand Down Expand Up @@ -214,6 +216,7 @@ def print_entry(label, value):
StructArray, ExtensionArray,
RunEndEncodedArray, Bool8Array, FixedShapeTensorArray,
JsonArray, OpaqueArray, UuidArray,
VariableShapeTensorArray,
scalar, NA, _NULL as NULL, Scalar,
NullScalar, BooleanScalar,
Int8Scalar, Int16Scalar, Int32Scalar, Int64Scalar,
Expand All @@ -231,7 +234,8 @@ def print_entry(label, value):
FixedSizeBinaryScalar, DictionaryScalar,
MapScalar, StructScalar, UnionScalar,
RunEndEncodedScalar, Bool8Scalar, ExtensionScalar,
FixedShapeTensorScalar, JsonScalar, OpaqueScalar, UuidScalar)
FixedShapeTensorScalar, JsonScalar, OpaqueScalar, UuidScalar,
VariableShapeTensorScalar)

# Buffers, allocation
from pyarrow.lib import (DeviceAllocationType, Device, MemoryManager,
Expand Down
Loading
Loading