GH-43170: [Swift] Add StructArray support to ArrowWriter#43439
Merged
kou merged 1 commit intoapache:mainfrom May 28, 2025
Merged
GH-43170: [Swift] Add StructArray support to ArrowWriter#43439kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
|
|
Member
Member
|
Thanks for the ping @kou |
kou
approved these changes
May 26, 2025
Member
There was a problem hiding this comment.
Suggested change
| switch arrowType.id { | |
| switch typeId { |
Member
|
@raulcd We're ready to move |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b5b6707. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support for Struct type has been added to the Swift ArrayReader. This change adds this support to the ArrowWriter.
What changes are included in this PR?
Updates to the ArrowWriter to support the Struct type.
Are these changes tested?
Yes, test included in PR