GH-44615: [C++] Add possibility to extract spans/byte offsets directly for compute.extract_regex #45577
+253
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashandishgar
force-pushed
the
extract_regex_span
branch
from
228c2c5 to
88da027
Compare
|
@pitrou could you review this issue? |
mapleFU
reviewed
Feb 22, 2025
github-actions
bot
added
awaiting committer review
Yes, this is a new compute function called extract_regex_span. Should I add changes somewhere? |
pitrou
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Thanks for this @arashandishgar . There are a number of things to improve in this PR even though the overall implementation is sound, see comments below.
|
Appreciate your feedback! I’ll look into it and follow up soon. |
arashandishgar
commented
Feb 25, 2025
pitrou
reviewed
Feb 25, 2025
arashandishgar
requested review from
assignUser,
jonkeane,
kou,
raulcd,
thisisnic and
westonpace
as code owners
github-actions
bot
added
Component: R
Component: Python
Component: Documentation
labels
|
sorry for my mistake what should I do? |
arashandishgar
force-pushed
the
extract_regex_span
branch
from
29ff6ea to
9442b40
Compare
github-actions
bot
removed
Component: R
Component: Python
Component: Documentation
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes, by dedicated unit tests.
Are there any user-facing changes?
No, except a new compute function.
compute.extract_regex#44615