GH-46153: [C++] Implement acero directory in Meson#46154
Conversation
|
Draft for now - this will require a rebase after #45830 gets merged, but the overall structure should not change |
|
|
WillAyd
force-pushed
the
meson-add-acero
branch
from
331bb59 to
895e3ab
Compare
|
GitHub issue should be |
raulcd
changed the title
|
|
|
@github-actions crossbow submit *meson |
|
Revision: d806c95ff656df8eb4f6167f59d830129f4afd98 Submitted crossbow builds: ursacomputing/crossbow @ actions-8f98bcb863
|
|
@kou if you have time to review this one, it looks like many of the remaining directories left to implement depend up on this. No rush of course - thanks! |
cpp/src/arrow/acero/meson.build
Outdated
There was a problem hiding this comment.
In general, arrow_test_dep should be placed after other Arrow related deps because arrow_test_dep depends on arrow_dep:
| dependencies: [arrow_test_dep, arrow_acero_dep], | |
| dependencies: [arrow_acero_dep, arrow_test_dep], |
cpp/src/arrow/acero/meson.build
Outdated
There was a problem hiding this comment.
| dependencies: [arrow_benchmark_dep, arrow_acero_dep, gmock_dep], | |
| dependencies: [arrow_acero_dep, arrow_benchmark_dep, gmock_dep], |
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit *meson |
github-actions
bot
added
awaiting change review
|
Revision: 02646eb Submitted crossbow builds: ursacomputing/crossbow @ actions-542871a8c4
|
|
@github-actions crossbow submit *meson |
|
Revision: 02646eb Submitted crossbow builds: ursacomputing/crossbow @ actions-725472e915
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dc09722. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
3 participants
Rationale for this change
Improves coverage of the Meson build system configuration
What changes are included in this PR?
This adds the Acero directory to Meson
Are these changes tested?
Yes
Are there any user-facing changes?
No