GH-47897: [C++][Python] Allow default column type for CSV columns#47898
Closed
cottrell wants to merge 2 commits intoapache:mainfrom
Closed
GH-47897: [C++][Python] Allow default column type for CSV columns#47898cottrell wants to merge 2 commits intoapache:mainfrom
cottrell wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
|
|
|
|
Member
Author
Yes! I did search for this but didn't find it. Definitely go with that one if it's already in progress or better. It is partly agentic yes. Interesting that someone else has also hitting this very minor but useful addition. I will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Users who want to coerce every CSV column to a single type currently have to pre-compute a schema or enumerate column names. Adding a default type on
ConvertOptionsremoves that friction (e.g. “read everything as string”).What changes are included in this PR?
ConvertOptions::column_typein C++ and honor it in the CSV reader when no per-column mapping existscsv.ConvertOptions(column_type=…)in PyArrow, with documentation updatesinclude_missing_columnsAre these changes tested?
make test-csvpytest python/pyarrow/tests/test_cpp_internals.pypytest python/pyarrowattempt times out in the dataset backpressure test on this environment (documented limitation)Are there any user-facing changes?
column_typeparameter onpyarrow.csv.ConvertOptionsComponent(s)
C++, Python