GH-48123 [C++][Float16] Reimplement arrow::WithinUlp and Enable it for float16 #48224
+161
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
reviewed
Nov 26, 2025
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
This is neat, thank you. A couple comments below, but looks good on the principle.
github-actions
bot
added
awaiting committer review
Contributor
Author
|
@pitrou Thank you for the review. I’ve checked all the comments and will apply your suggestions in the coming days. |
andishgar
force-pushed
the
ulp_distance
branch
from
67f5d3b to
f91d298
Compare
pitrou
approved these changes
Dec 8, 2025
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM, thank you @andishgar ! I've just pushed a very minor change and will merge if CI is ok.
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: 0597736 Submitted crossbow builds: ursacomputing/crossbow @ actions-aeed0cd233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Refer to this comment. Additionally, this change enables
arrow::WithinUlpforfloat16.What changes are included in this PR?
Re-implement
arrow::WithinUlpand enable it forfloat16, including relevant tests for corner cases around powers of two andFloat16.Are these changes tested?
Yes, I ran the relevant unit tests.
Are there any user-facing changes?
No.