GH-33241: [Archery] Replace github3 with pygithub#48886
GH-33241: [Archery] Replace github3 with pygithub#48886fangchenli wants to merge 5 commits intoapache:mainfrom
Conversation
|
|
|
|
fangchenli
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the PR, awesome work. The changes look great in general. I'll have to take some time to do some validation as crossbow isn't extensively tested at the moment. Can you remove this one while I find some time to test it?
arrow/ci/conda_env_archery.txt
Line 22 in 894d6a3
|
Failures are unrelated, will be fixed once the following issue closed. It has a PR ready to be merged: |
There was a problem hiding this comment.
Changes look good to me. Thanks @fangchenli
@kou I plan to merge this and if we find any small issue not covered by tests during crossbow runs we can fix them.
I haven't validated manually the different cases but have reviewed the changes.
|
|
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
It makes sense.
@fangchenli BTW, I'm not sure why you worked on this but are you interested in GitHub API related issue? We want to complete #47340 but we need to update our GitHub API usage too. (Changing Type: XXX issue label to XXX issue type in our development scripts.) Do you want to work on it?
| # NOTE: We access the private _Github__requester to get response | ||
| # headers, as PyGithub doesn't expose the token expiration header | ||
| # through its public API. This may break with future PyGithub updates. |
There was a problem hiding this comment.
Could you open an issue to PyGithub to add a public API for this?
| # Since github has changed something the asset uploading via requests | ||
| # got instable, so prefer the cURL alternative. | ||
| # Potential cause: | ||
| # sigmavirus24/github3.py/issues/779#issuecomment-379470626 |
There was a problem hiding this comment.
Can we remove curl fallback with PyGithub?
3 participants
Rationale for this change
Archery currently uses both pygithub and github3. It's unnecessary and increases maintenance burden.
What changes are included in this PR?
Replace all github3 usage with pygithub.
Are these changes tested?
Yes, unittests added.
Are there any user-facing changes?
No.