MINOR: [Python] Array.from_buffers accepts None buffers#49163
MINOR: [Python] Array.from_buffers accepts None buffers#49163AlenkaF merged 2 commits intoapache:mainfrom
Array.from_buffers accepts None buffers#49163Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
I can in fact not... I think this classifies as a minor change, but I seem to lack permissions to rename my own PR... The button for is isn't showing. Must be a GH thing. |
Array.from_buffers accepts None buffersArray.from_buffers accepts None buffers
@AlenkaF would you prefer a separate PR or should I extend this one? |
|
Please, extend this one. |
|
Done. While at it, I also saw that |
Array.from_buffers accepts None buffersArray.from_buffers accepts None buffers
|
@AlenkaF opinions on |
|
@robsdedude I think arrow/python/pyarrow/array.pxi Lines 4403 to 4404 in f2b4e34 and the docstrings are correct there: arrow/python/pyarrow/array.pxi Line 4414 in f2b4e34 |
|
Thanks! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b095098. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Fix the docs. It seems this is a feature and not just happens to work as the code a little below even has an explicit comment:
arrow/python/pyarrow/array.pxi
Line 1347 in 0dfae70
What changes are included in this PR?
Document that
Array.from_bufferstakes alist[Buffer | None]instead of strictlylist[Buffer].Are these changes tested?
not applicable
Are there any user-facing changes?
Yes, but not in an API sense :)