Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cpp/src/parquet/stream_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ StreamReader::StreamReader(std::unique_ptr<ParquetFileReader> reader)
auto schema = file_metadata_->schema();
auto group_node = schema->group_node();

if (schema->num_columns() == 0) {
throw ParquetException("StreamReader does not support empty schemas.");
}
nodes_.resize(schema->num_columns());

for (auto i = 0; i < schema->num_columns(); ++i) {
Expand Down
1 change: 1 addition & 0 deletions cpp/src/parquet/stream_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class PARQUET_EXPORT StreamReader {
// assigned afterwards.
StreamReader() = default;

/// Reader must have at least one field defined in its schema.
explicit StreamReader(std::unique_ptr<ParquetFileReader> reader);

~StreamReader() = default;
Expand Down
18 changes: 18 additions & 0 deletions cpp/src/parquet/stream_reader_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
#include <memory>

#include "arrow/io/file.h"
#include "arrow/io/memory.h"
#include "arrow/util/decimal.h"
#include "parquet/exception.h"
#include "parquet/file_writer.h"
#include "parquet/test_util.h"

namespace parquet {
Expand Down Expand Up @@ -251,6 +253,22 @@ TEST_F(TestStreamReader, DefaultConstructed) {
EXPECT_EQ(0, os.SkipRows(100));
}

TEST(StreamReaderEmptySchema, ThrowsOnConstruction) {
PARQUET_ASSIGN_OR_THROW(auto buffer_os, ::arrow::io::BufferOutputStream::Create());

auto empty_schema = std::static_pointer_cast<schema::GroupNode>(
schema::GroupNode::Make("schema", Repetition::REQUIRED, schema::NodeVector{}));

auto file_writer = ParquetFileWriter::Open(buffer_os, empty_schema);
file_writer->Close();

PARQUET_ASSIGN_OR_THROW(auto buffer, buffer_os->Finish());
auto buffer_reader = std::make_shared<::arrow::io::BufferReader>(buffer);
auto file_reader = ParquetFileReader::Open(buffer_reader);

EXPECT_THROW(StreamReader{std::move(file_reader)}, ParquetException);
}

TEST_F(TestStreamReader, TypeChecking) {
bool b;
std::string s;
Expand Down
Loading