Skip to content

GH-49426: [Python] Do not build pyarrow-stubs on emscripten builds #49427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rok merged 3 commits into from
Mar 3, 2026
Merged

GH-49426: [Python] Do not build pyarrow-stubs on emscripten builds #49427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b666d1
GH-49426: [Python] Do not build pyarrow-stubs on emscripten builds
raulcd Mar 2, 2026
3bd04d8
Use 127.0.0.1 for the server instead of 0.0.0.0 as chrome might silen…
raulcd Mar 3, 2026
d5b2027
Attempt to fix tzdata related tests on emscripten
raulcd Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/scripts/run_emscripten_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def end_headers(self):
def run_server_thread(dist_dir, q):
global _SERVER_ADDRESS
os.chdir(dist_dir)
server = http.server.HTTPServer(("", 0), TemplateOverrider)
server = http.server.HTTPServer(("127.0.0.1", 0), TemplateOverrider)
q.put(server.server_address)
print(f"Starting server for {dist_dir} at: {server.server_address}")
server.serve_forever()
Expand Down Expand Up @@ -280,6 +280,7 @@ def _load_pyarrow_in_runner(driver, wheel_name):
if "pyarrow" not in sys.modules:
await micropip.install("hypothesis")
import pyodide_js as pjs
await pjs.loadPackage("tzdata")
await pjs.loadPackage("numpy")
await pjs.loadPackage("pandas")
import pytest
Expand Down
3 changes: 3 additions & 0 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ def run(self):

def _update_stubs(self):
"""Copy stubs to build directory, then inject docstrings into the copies."""
if is_emscripten:
# stubs are not supported in Emscripten build
return
Comment on lines +129 to +131
Copy link
Member

@rok rok Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

stubs_dir = pjoin(setup_dir, 'pyarrow-stubs')
if not os.path.exists(stubs_dir):
return
Expand Down
Loading