ARTEMIS-6165 start/stop button on lock coordinators - #217
Merged
Merged
Conversation
co-authored with Claude
Contributor
Author
|
@andytaylor I did this change by using Claude. it would be nice to have the button after we merge ARTE4MIS-6163. Don't know if you can think of a better way. |
grgrzybek
approved these changes
Sep 30, 2026
grgrzybek
left a comment
Contributor
There was a problem hiding this comment.
Looks good - and thanks for the missing <Th> ;)
brusdev
approved these changes
Sep 30, 2026
brusdev
left a comment
Member
There was a problem hiding this comment.
LGTM — I did a brief test with FileBasedLockManager.
Outside the scope of this PR, it might be worth making the lock coordinators table visible upfront. That way, users know the feature is available, and we avoid sudden UI changes in the status section due to the config.
<lock-coordinators>
<lock-coordinator name="demo-lock-coordinator"
auto-start="true">
<class-name>org.apache.activemq.artemis.lockmanager.file.FileBasedLockManager</class-name>
<check-period>5000</check-period>
<properties>
<property key="locks-folder" value="${artemis.instance}/data/lock-coordinator"/>
</properties>
</lock-coordinator>
</lock-coordinators>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
co-authored with Claude