Skip to content

ARTEMIS-6165 start/stop button on lock coordinators - #217

Merged
brusdev merged 1 commit into
apache:mainfrom
clebertsuconic:ARTEMIS-6165
Sep 30, 2026
Merged

brusdev merged 1 commit into
apache:mainfrom
clebertsuconic:ARTEMIS-6165

Conversation

@clebertsuconic

Copy link
Copy Markdown
Contributor

co-authored with Claude

@clebertsuconic

Copy link
Copy Markdown
Contributor Author

@andytaylor I did this change by using Claude. it would be nice to have the button after we merge ARTE4MIS-6163. Don't know if you can think of a better way.

@grgrzybek grgrzybek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - and thanks for the missing <Th> ;)

@brusdev brusdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I did a brief test with FileBasedLockManager.

Outside the scope of this PR, it might be worth making the lock coordinators table visible upfront. That way, users know the feature is available, and we avoid sudden UI changes in the status section due to the config.

      <lock-coordinators>
         <lock-coordinator name="demo-lock-coordinator"
                           auto-start="true">
            <class-name>org.apache.activemq.artemis.lockmanager.file.FileBasedLockManager</class-name>
            <check-period>5000</check-period>
            <properties>
               <property key="locks-folder" value="${artemis.instance}/data/lock-coordinator"/>
            </properties>
         </lock-coordinator>
      </lock-coordinators>

@brusdev
brusdev merged commit cc3ea0e into apache:main Sep 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants