[AURON #1814][Correctness Testing] Spark 3.3 - Add Sort operator related tests #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richox
approved these changes
Jan 17, 2026
Contributor
Author
|
@richox Can we merge this in? Thanks! |
Contributor
Author
|
@cxzl25 Could you PTAL? Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive correctness tests for the Sort operator in Spark 3.3 as part of the broader Auron correctness testing effort (issue #1745). The tests verify sort-related functionality including range partitioning, local sorting within partitions, exchange reuse optimization, and edge cases for large expressions and view changes.
Changes:
- Added 5 new test cases in AuronDataFrameSuite covering repartitionByRange, distributeBy/localSort, exchange reuse, large CaseWhen expressions, and view change scenarios
- Configured test suite to exclude the original Spark DataFrameSuite tests that have Auron-specific implementations
- Added exclusions for tests that fail due to native execution differences
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| auron-spark-tests/spark33/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | New test suite with 5 sort-related tests and helper methods for verifying aggregation and shuffle behavior |
| auron-spark-tests/spark33/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Configured AuronDataFrameSuite with appropriate test exclusions for Auron-specific implementations and known failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
auron-spark-tests/spark33/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala
Show resolved
Hide resolved
cxzl25
approved these changes
Jan 21, 2026
Contributor
Author
|
Thanks! @cxzl25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1814
Rationale for this change
This change is part of the effort for enhancing Auron's correctness testing (#1745).
What changes are included in this PR?
This change adds supports for sort operator related tests.
Are there any user-facing changes?
N/A
How was this patch tested?
Existing unit tests