AVRO-4119: [java] Make Nullable and NotNull annotations configurable #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nullSafeAnnotationNullable and nullSafeAnnotationNotNull configuration options to allow specifying the exact annotations to use when createNullSafeAnnotations is enabled. This allows using annotations besides the JetBrains annotations (which remain the default for backward-compatibility).
opwvhk
reviewed
Feb 21, 2025
lang/java/tools/src/test/compiler/input/nullsafeannotationsfieldstest.avsc
Show resolved
Hide resolved
opwvhk
requested changes
Feb 21, 2025
|
Is the failing interop test relevant? Tbh I'm not sure I understand what the problem with it is. |
opwvhk
approved these changes
Feb 22, 2025
Looks like a classpath issue: it seems to use an old version of the compiler (without your change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds the nullSafeAnnotationNullable and nullSafeAnnotationNotNull configuration options to the Java code generator, making it possible to specify the exact annotations to use when createNullSafeAnnotations is enabled.
This allows using nullability annotations besides the JetBrains annotations (which remain the default for backward compatibility), fixing AVRO-4119.
Verifying this change
This change added tests and can be verified as follows:
Documentation