AVRO-4026: [C++] Allow non-string custom attributes #3344
+76
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR takes a different approach than #3308, #3069, #3064 and #3266 to fix the non-string custom attributes. It extends the
CustomAttributes::addAttribute(const std::string &name, const std::string &value)
with a third parameterbool addQuotes
with default value set totrue
to support adding non-string values explicitly and keep backward compatibility.Verifying this change
json->schema->json
andschema->json->schema
round trips have preserved non-string attributes correctly.Documentation