GCS client library migration in Java SDK - part 3

[shunping]

• Add open and create methods for GcsUtilV2.
• Add bridge channel classes to ensure we keep the function signature as much as we can.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, part three of the GCS client library migration, focuses on enabling fundamental read and write capabilities using the updated GcsUtilV2. It introduces new methods for opening and creating GCS files, along with adapter classes to ensure seamless integration with existing Java I/O channel interfaces. This change is crucial for progressing the migration while maintaining functional parity and allowing for a controlled rollout of the new client library features.

Highlights

• GcsUtilV2 Read/Write Operations: Implemented open and create methods within GcsUtilV2 to enable direct read and write operations to Google Cloud Storage using the new client library.
• Channel Bridge Classes: Introduced GcsSeekableByteChannel and GcsWritableByteChannel to act as bridge classes, adapting the com.google.cloud library's ReadChannel and WriteChannel to the standard Java SeekableByteChannel and WritableByteChannel interfaces, maintaining API compatibility.
• GcsUtil Delegation: Modified the existing GcsUtil class to conditionally delegate open and create calls to the new GcsUtilV2 implementation when the V2 delegate is initialized, facilitating a gradual migration.
• Integration Tests: Added new integration tests (testRead and testWriteAndRead) in GcsUtilParameterizedIT to verify the functionality of the new GCS read and write operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[shunping]

cc'ed @BenWhitehead

[github-actions]

Reminder, please take a look at this pr: @ahmedabu98

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @Abacn

[Abacn]

waiting on author

[shunping]

r: @Abacn for java code review in general.

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[clairemcginty]

hi @shunping! just wondering: is there any plan to port the use_grpc_for_gcs experiment to GcsUtilV2? I see it's an option in GcsUtilV1, but not V2. IIRC you can opt into GRPC in the google-cloud-storage API just by using the StorageOptions.grpc() builder.