Skip to content

Remove google-perftools from the default image.#39323

Merged
tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:gperf
Jul 14, 2026
Merged

Remove google-perftools from the default image.#39323
tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:gperf

Conversation

@tvalentyn

@tvalentyn tvalentyn commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Follow up for #38853 #20298.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Python SDK container image by removing the google-perftools dependency. This change reduces the size of the default image and encourages a more modular approach for users who require specific profiling tools like tcmalloc.

Highlights

  • Container Optimization: Removed the google-perftools package from the Python SDK container image to reduce the default footprint.
  • Breaking Change Documentation: Updated CHANGES.md to notify users that tcmalloc profiling now requires manual installation of google-perftools in custom container images.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the google-perftools package from the Python SDK container images and documents this breaking change in CHANGES.md. The review feedback suggests minor formatting and grammatical improvements to the release notes entry for better clarity and consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CHANGES.md Outdated
## Breaking Changes

* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).
* (Python) Removed google-perftools from the SDK container images. Users who wish to use `--profiler_agent=tcmalloc` should install google-perftools apt package in their custom container images separately.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency, consider wrapping google-perftools in backticks as it refers to a package name, capitalizing 'APT', and adding the article 'the' to make the sentence grammatically complete.

Suggested change:

* (Python) Removed `google-perftools` from the SDK container images. Users who wish to use `--profiler_agent=tcmalloc` should install the `google-perftools` APT package in their custom container images separately.

@shunping shunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn
tvalentyn merged commit a6f2ff4 into apache:master Jul 14, 2026
97 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants