Skip to content

Fix CdapIO dependency #39393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Jul 21, 2026
+6 −1
Merged

Fix CdapIO dependency #39393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ class BeamModulePlugin implements Plugin<Project> {
def autoservice_version = "1.0.1"
def aws_java_sdk2_version = "2.20.162"
def cassandra_driver_version = "3.10.2"
def cdap_version = "6.5.1"
def cdap_version = "6.11.4"
def checkerframework_version = "3.42.0"
def classgraph_version = "4.8.162"
def delta_lake_version = "4.2.0"
Expand Down
5 changes: 5 additions & 0 deletions sdks/java/io/cdap/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,8 @@ test {
// Open java.lang for Gson reflection on StackTraceElement under Java 17+
jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
}

// spark3_streaming depends on old 'org.lz4:lz4-java'; conflict with kafka-clients:3.9.2
configurations.all {
resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 'at.yawk.lz4')

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The module notation 'at.yawk.lz4' is incomplete as it only specifies the group ID. It should include the artifact ID as well, which is 'at.yawk.lz4:lz4-java'. Passing an incomplete module notation will prevent the capability conflict resolution helper from correctly identifying and resolving the conflict.

    resolveCapabilitiesConflict(it, 'org.lz4:lz4-java', 'at.yawk.lz4:lz4-java')

@damccorm damccorm Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this technically could help, but is unnecessary -

beam/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Line 973 in 7735b39

def candidate = candidates.find { it.id.toString().contains(preferred) }

}
Loading