-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add registerSqlOperator() to BeamSqlEnv for custom SQL operators #39432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damccorm
wants to merge
1
commit into
master
Choose a base branch
from
backport-f53e1abe-register-sql-operator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
...src/test/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnvRegisterOperatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.extensions.sql.impl; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| import org.apache.beam.sdk.extensions.sql.impl.rel.BaseRelTest; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlFunction; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlFunctionCategory; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlIdentifier; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlKind; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlOperator; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.SqlSyntax; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.parser.SqlParserPos; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.type.OperandTypes; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.type.ReturnTypes; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.validate.SqlNameMatcher; | ||
| import org.apache.beam.vendor.calcite.v1_40_0.org.apache.calcite.sql.validate.SqlNameMatchers; | ||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * Tests for {@link BeamSqlEnv#registerSqlOperator(SqlOperator)} and the session-scoped operator | ||
| * table in {@link JdbcConnection}. | ||
| */ | ||
| public class BeamSqlEnvRegisterOperatorTest extends BaseRelTest { | ||
|
|
||
| /** A simple custom function for testing, not present in the default operator table. */ | ||
| private static final String CUSTOM_FUNCTION_NAME = "BEAM_TEST_CUSTOM_FUNC"; | ||
|
|
||
| private static SqlFunction createCustomFunction() { | ||
| return new SqlFunction( | ||
| CUSTOM_FUNCTION_NAME, | ||
| SqlKind.OTHER_FUNCTION, | ||
| ReturnTypes.INTEGER, | ||
| null, | ||
| OperandTypes.NUMERIC, | ||
| SqlFunctionCategory.USER_DEFINED_FUNCTION); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExtraOperatorTableStartsEmpty() { | ||
| // A fresh env should have an empty extra operator table | ||
| BeamSqlEnv freshEnv = BeamSqlEnv.readOnly("empty_test", new java.util.HashMap<>()); | ||
| assertTrue( | ||
| "Extra operator table should be empty on a fresh env", | ||
| freshEnv.connection.getExtraOperatorTable().getOperatorList().isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRegisterSqlOperator_addsToExtraOperatorTable() { | ||
| SqlFunction customFunc = createCustomFunction(); | ||
| env.registerSqlOperator(customFunc); | ||
|
|
||
| // Verify the operator is in the extra operator table | ||
| assertTrue( | ||
| "Registered operator should be present in the extra operator table", | ||
| env.connection.getExtraOperatorTable().getOperatorList().contains(customFunc)); | ||
| assertEquals(1, env.connection.getExtraOperatorTable().getOperatorList().size()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRegisterSqlOperator_makesOperatorResolvableByName() { | ||
| SqlFunction customFunc = createCustomFunction(); | ||
| env.registerSqlOperator(customFunc); | ||
|
|
||
| // Verify the operator is resolvable by name in the extra operator table | ||
| SqlNameMatcher nameMatcher = SqlNameMatchers.withCaseSensitive(false); | ||
| java.util.List<SqlOperator> resolvedOps = new java.util.ArrayList<>(); | ||
| env.connection | ||
| .getExtraOperatorTable() | ||
| .lookupOperatorOverloads( | ||
| new SqlIdentifier(CUSTOM_FUNCTION_NAME, SqlParserPos.ZERO), | ||
| SqlFunctionCategory.USER_DEFINED_FUNCTION, | ||
| SqlSyntax.FUNCTION, | ||
| resolvedOps, | ||
| nameMatcher); | ||
|
|
||
| assertFalse( | ||
| "Custom operator should be resolvable by name after registration", resolvedOps.isEmpty()); | ||
| assertTrue( | ||
| "The resolved operator should be the one we registered", resolvedOps.contains(customFunc)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(formatting) import the names