Skip to content

Fix flaky BigQuery persistent retry test - #39539

Merged
shunping merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-bigquery-persistent-retry-flake
Jul 29, 2026
Merged

Fix flaky BigQuery persistent retry test#39539
shunping merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-bigquery-persistent-retry-flake

Conversation

@bvolpato

Copy link
Copy Markdown
Contributor

Fixes #39526.

Summary

The persistent retry test asserts one initial BigQuery call plus three retries. Its default pipeline can select Prism, where runner-dependent execution sometimes invokes the mocked retry path twice. The reported failure saw 8 calls instead of 4.

Pin this runner-specific mocking test to FnApiRunner, matching the adjacent intermittent retry test. Production code is unchanged.

Validation

  • Confirmed failing CI trace contained two four-attempt retry sequences
  • Unchanged test: 50/50 local passes, consistent with a rare scheduling flake
  • Python 3.12 cloud tox target after fix: 2 passed
  • Patched timeout case stress: 50/50 passes
  • YAPF 0.43.0 and Ruff 0.15.7 passed on changed file

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@shunping
shunping merged commit 08dc50a into apache:master Jul 29, 2026
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: BigQueryStreamingInsertsErrorHandling test is flaky

2 participants