Skip to content

[OpenTelemetry] Redistribute - trace propagation #39590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stankiewicz merged 1 commit into from
Aug 3, 2026
Merged

[OpenTelemetry] Redistribute - trace propagation #39590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Redistribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
package org.apache.beam.sdk.transforms;

import com.google.auto.service.AutoService;
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ThreadLocalRandom;
import org.apache.beam.model.pipeline.v1.RunnerApi;
import org.apache.beam.sdk.annotations.Internal;
Expand Down Expand Up @@ -182,14 +185,18 @@ public void processElement(
@Element KV<K, ValueInSingleWindow<V>> kv,
OutputReceiver<KV<K, V>> outputReceiver) {
// todo #33176 specify additional metadata in the future
outputReceiver
.builder(KV.of(kv.getKey(), kv.getValue().getValue()))
.setTimestamp(kv.getValue().getTimestamp())
.setWindow(kv.getValue().getWindow())
.setPaneInfo(kv.getValue().getPaneInfo())
.setCausedByDrain(kv.getValue().getCausedByDrain())
.setValueKind(kv.getValue().getValueKind())
.output();
Context c = kv.getValue().getOpenTelemetryContext();
try (Scope ignored =
Objects.requireNonNullElse(c, Context.root()).makeCurrent()) {
Comment thread
Abacn marked this conversation as resolved.
outputReceiver
.builder(KV.of(kv.getKey(), kv.getValue().getValue()))
.setTimestamp(kv.getValue().getTimestamp())
.setWindow(kv.getValue().getWindow())
.setPaneInfo(kv.getValue().getPaneInfo())
.setCausedByDrain(kv.getValue().getCausedByDrain())
.setValueKind(kv.getValue().getValueKind())
.output();
}
}
}));
}
Expand Down
4 changes: 3 additions & 1 deletion sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reify.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.beam.sdk.transforms;

import io.opentelemetry.context.Context;
import org.apache.beam.sdk.coders.Coder;
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.VoidCoder;
Expand Down Expand Up @@ -162,7 +163,8 @@ public void processElement(
pc.currentRecordId(),
pc.currentRecordOffset(),
causedByDrain,
null,
Context
Comment thread
Abacn marked this conversation as resolved.
.current(), // Otel context is not exposed via process context
valueKind)));
}
}))
Expand Down
Loading