[Dataflow Streaming] Mark worker as unhealthy in presence of stuck commits - #39666
Merged
Conversation
…mmits Getting rid of the commit invalidation logic simplifies work lifecycle. When worker is marked as unhealthy backend will restart the worker.
Contributor
Author
|
R: @scwhittle |
Contributor
|
Assigning reviewers: R: @tvalentyn added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
scwhittle
requested changes
Aug 10, 2026
| int stuckCommitDurationMillis = | ||
| options.isEnableStreamingEngine() ? Math.max(options.getStuckCommitDurationMillis(), 0) : 0; | ||
| if (stuckCommitDurationMillis <= 0) { | ||
| return true; |
Contributor
There was a problem hiding this comment.
nit: how about nesting the loop under an if stuckCommitsDuration > 0, instead of the early return true. Then we can add other things that return false if it's unhealthy and not accidentally skip them.
| assertThat(invalidatedCommits).containsEntry(shardedKey2, stuckWork2.id()); | ||
| verify(computationStateCache).invalidate(shardedKey1.key(), shardedKey1.shardingKey()); | ||
| verify(computationStateCache).invalidate(shardedKey2.key(), shardedKey2.shardingKey()); | ||
| assertThat(activeWorkState.hasStuckCommits(Instant.now())).isTrue(); |
Contributor
There was a problem hiding this comment.
validate it is false with timestamp closer to start procesisng timestamp
scwhittle
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting rid of the commit invalidation logic simplifies work lifecycle. When worker is marked as unhealthy backend will recreate the worker.
Ran a job with a delay added in commit path and verified that the worker got recreated.