Skip to content

Issue 2408: [documentation] fix default ledger manager and Qw value in documentation#2413

Merged
jiazhai merged 1 commit into
apache:masterfrom
lifepuzzlefun:fix_documentation
Nov 10, 2020
Merged

Issue 2408: [documentation] fix default ledger manager and Qw value in documentation#2413
jiazhai merged 1 commit into
apache:masterfrom
lifepuzzlefun:fix_documentation

Conversation

@lifepuzzlefun

@lifepuzzlefun lifepuzzlefun commented Sep 12, 2020

Copy link
Copy Markdown
Contributor

fix #2408

  1. fix documentation concept part about default ledger manager.
  2. fix documentation protocol part about missing Qw value.

Descriptions of the changes in this PR:

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

1. fix documentation concept part about default ledger manager.
2. fix documentation protocol part about  missing Qw value.
@lifepuzzlefun lifepuzzlefun changed the title [Issue 2408] [documentation] fix default ledger manager and Qw value in documentation Issue 2408: [documentation] fix default ledger manager and Qw value in documentation Sep 12, 2020

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@jiazhai jiazhai merged commit 22d7d0e into apache:master Nov 10, 2020
@jiazhai jiazhai added this to the 4.12.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[documentation] "The flat ledger manager is the default" is a false claim

3 participants